fix test for php 8.5#194
Merged
bobstrecansky merged 1 commit intoopen-telemetry:mainfrom Aug 25, 2025
Merged
Conversation
Deprecated: Increment on non-numeric string is deprecated, use str_increment() instead in /home/runner/work/opentelemetry-php-instrumentation/opentelemetry-php-instrumentation/ext/tests/multiple_hooks_modify_params.php
bobstrecansky
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test just started failing against php nightly, because it uses a technique that will be deprecated:
Deprecated: Increment on non-numeric string is deprecated, use str_increment() instead in /home/runner/work/opentelemetry-php-instrumentation/opentelemetry-php-instrumentation/ext/tests/multiple_hooks_modify_params.php
Update the test to use numerics instead of a string.
ref: php/php-src@93716be