Add windows static build support#164
Add windows static build support#164brettmc merged 4 commits intoopen-telemetry:mainfrom crazywhalecc:patch-1
Conversation
|
Hi @crazywhalecc thanks for this! Is there a way we can test this build as part of our github actions, and do you think we should also build/publish a binary for it? |
|
Thanks for the quick reply. I don't know much about the structure and CI of the opentelemetry project at the moment, but this change should only affect people who want to statically compile extensions to PHP, while the traditional way of distributing dlls is not affected. That is, we don't need to redistribute dlls or other binaries. To test this PR, we need to start by downloading php-src locally or writing an additional GHA. I'm working on adding opentelemetry support to the static-php-cli project, where the results are already checked by a simple sanity check, but I haven't tested each method in depth or hooked into more comprehensive extension testing. If the project requires additional code to fully support static compilation, please point it out. |
|
It looks like the win/8.0/ts build is broken with this change. |
|
I may have found the reason. In the When dynamically compiling EXTENSION('opentelemetry', 'opentelemetry.c otel_observer.c', PHP_OPENTELEMETRY_SHARED);At the same time, I found that this CI not only had problems with 8.0-ts, but all versions of ts tests failed, but the checks of other versions were skipped. |
Can you add that fix to this PR and we will see if it un-breaks |
|
I've tried to fix this, and so far I've been able to compile and test locally and it seems to work fine. |
This patch will allow opentelemetry compiling with php-src statically on Windows.