dont emit warnings by default#156
Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom Jan 20, 2025
Merged
Conversation
adds a new ini entry, opentelemetry.display_warnings, default=off, to control whether warnings are emitted.
ChrisLightfootWild
approved these changes
Jan 15, 2025
bobstrecansky
approved these changes
Jan 15, 2025
Contributor
|
Building it for Alpinelinux faced that s390x arch failed new test TEST 66/67 [tests/with_span/disable.phpt]
========DIFF========
- Warning: %s: OpenTelemetry: WithSpan attribute found but attribute hooks disabled in Unknown on line %d
string(4) "test"
========DONE========
FAIL Check if attribute hooks can be disabled by config [tests/with_span/disable.phpt] PS reproducible in both edge and 3.21 (stable) branches |
andypost
added a commit
to andypost/opentelemetry-php-instrumentation
that referenced
this pull request
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a new ini entry, opentelemetry.display_warnings, default=off, to control whether warnings are emitted.
Closes: open-telemetry/opentelemetry-php#1476