fix 8.4 segfaults, test against PHP nightly#153
Merged
brettmc merged 9 commits intoopen-telemetry:mainfrom Sep 9, 2024
Merged
Conversation
- build against PHP nightly on PR and daily schedule - use setup-php for linux builds (which drops Alpine builds)
Contributor
|
FYI using this patch it shows failure on 32-bits like this |
Contributor
Author
Was able to replicate this using i386/alpine docker image... |
- remove the ability to pass complex items as attributes (since the spec already disallows them, they'd get dropped later anyway) - update alpine dockerfile to also support 32bit builds, which enables local testing against a 32bit platform
Contributor
Author
|
It should be green now against 32bit builds, @andypost |
andypost
reviewed
Sep 8, 2024
Contributor
|
Thank you! It passed on all arches! btw I noticed that CI here is not using latest stable Alpine version (3.20) |
bobstrecansky
approved these changes
Sep 9, 2024
LionsAd
pushed a commit
to LionsAd/opentelemetry-php-instrumentation
that referenced
this pull request
Jan 16, 2025
* test against PHP nightly - build against PHP nightly on PR and daily schedule - use setup-php for linux builds (which drops Alpine builds) * fix 8.4 segfaults * fix 32bit tests - remove the ability to pass complex items as attributes (since the spec already disallows them, they'd get dropped later anyway) - update alpine dockerfile to also support 32bit builds, which enables local testing against a 32bit platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: open-telemetry/opentelemetry-php#1376