k8s container id detection#191
Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom Sep 15, 2023
Merged
Conversation
update container detection to follow current best-practise, per bug report. we should check v1 then v2, and a few other updates I ripped off from java's implementation. adding tests for k8s and podman, and break inline content out into fixtures.
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
============================================
+ Coverage 28.60% 28.87% +0.26%
- Complexity 472 474 +2
============================================
Files 47 47
Lines 1755 1763 +8
============================================
+ Hits 502 509 +7
- Misses 1253 1254 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
pdelewski
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update container detection to follow current best-practise, per bug report. we should check v1 then v2, and a few other updates I ripped off from java's implementation. adding tests for k8s and podman, and break inline content out into fixtures.
Fixes: open-telemetry/opentelemetry-php#1114