fix(opentelemetry-instrumentation-http): Support http headers as array #5693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Member
|
This is a draft and has conflicts. Are you planning to still carry on with this PR? |
Member
|
Closing this PR as it is marked as draft and has conflicts. Please feel free to open a new PR if you're still interested in working on this. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
httppackage in Node actually supports receiving the headers as an array of strings.The definition file was updated accordingly and there is an open PR for the documentation as well.
Short description of the changes
Update NodeJS definition file and add support for headers array.
Type of change
How Has This Been Tested?
Still working on the unit test, something is not working for me :(
Checklist: