Skip to content

docs(sdk-metrics): Update Histogram docs to reflect upper bound inclusivity #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

docs(sdk-metrics): Update Histogram docs to reflect upper bound inclusivity #4829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3169c8
docs(sdk-metrics): Move 30 into 21-30 bucket
danielpatrickdotdev Jun 27, 2024
da4f828
Merge branch 'main' into small-docs-fix
hectorhdzg Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk-metrics/src/aggregator/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface Histogram {
*
* buckets: {
* boundaries: [10, 20, 30],
* counts: [3, 3, 1, 2],
* counts: [3, 3, 2, 1],
Copy link
Member

@hectorhdzg hectorhdzg Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to mention what spec describe here in the notes maybe, so is clear why the counts are like that. "buckets express the number of values that are greater than their lower bound and less than or equal to their upper bound."

* }
*/
buckets: {
Expand Down