fix: Update import-in-the-middle
#4806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
approved these changes
Jun 19, 2024
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Awesome, thanks. I'll merge this in.
I think now we can now also consider changing the dependency to import-in-the-middle to a caret range as many of the issues we were dealing with in previous versions are now resolved.
Contributor
Author
That would reduce the workload! Does iitm have tests that cover the things otel rely on? |
Member
|
@timfish yes it does. The main reason we pinned it was nodejs/import-in-the-middle#57. @trentm added tests for it in nodejs/import-in-the-middle#66. @timfish feel free to open the PR to use a caret range, then I'll merge it in :) |
This was referenced Jul 12, 2024
Closed
Closed
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* fix: Update `import-in-the-middle` * add changelog entry * linting is important
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import-in-the-middlehas had a few more bug fixes which have been released as v1.8.1 so I've bumper the version. This also included fixed types so no more type casting throughunknownto get the types working!The v1.8.0 release has also been added to Github so I updated the previous changelog entry to point to that.