refactor(instrumentation-xhr): use exported strings for semantic attr… #4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes Signed-off-by: Prashansa Kulshrestha <[email protected]>
Signed-off-by: Prashansa Kulshrestha <[email protected]>
24 tasks
pichlermarc
reviewed
May 6, 2024
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Overall looks good, just one nit.
experimental/packages/opentelemetry-instrumentation-xml-http-request/test/xhr.test.ts
Show resolved
Hide resolved
…SE_CONTENT_SIZE to new exported string Signed-off-by: Prashansa Kulshrestha <[email protected]>
JamieDanielson
approved these changes
Jun 3, 2024
pichlermarc
approved these changes
Jun 4, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
open-telemetry#4681) * refactor(instrumentation-xhr): use exported strings for semantic attributes Signed-off-by: Prashansa Kulshrestha <[email protected]> * Updated changelog entry with PR id and link Signed-off-by: Prashansa Kulshrestha <[email protected]> * Changed normal string to template string and replaced old HTTP_RESPONSE_CONTENT_SIZE to new exported string Signed-off-by: Prashansa Kulshrestha <[email protected]> --------- Signed-off-by: Prashansa Kulshrestha <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
Replace SemanticAttributes.* with specific exported strings for xml-http-request instrumentation package.
Type of change
Please delete options that are not relevant.
Refactoring change which removes the use of deprecated SemanticAttributes.*
How Has This Been Tested?
Checklist: