Remove domain from the Events API #4569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4569 +/- ##
==========================================
+ Coverage 92.84% 92.85% +0.01%
==========================================
Files 328 328
Lines 9494 9494
Branches 2040 2040
==========================================
+ Hits 8815 8816 +1
+ Misses 679 678 -1
|
martinkuba
force-pushed
the
remove-event-domain
branch
from
3fb88d8 to
73fbda8
Compare
MSNev
approved these changes
Mar 21, 2024
scheler
approved these changes
Mar 24, 2024
pichlermarc
approved these changes
Mar 25, 2024
This was referenced May 28, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* removed domain from the events API * lint * updated changelog --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
event domainwas removed from the specification in this PR open-telemetry/opentelemetry-specification#3749.Fixes # open-telemetry/opentelemetry-specification#2994
Short description of the changes
Type of change