Skip to content

fix(instrumentation)!: pin import-in-the-middle@1.7.1 - #4441

Merged
pichlermarc merged 7 commits into
open-telemetry:mainfrom
dynatrace-oss-contrib:fix/iitm-dep
Jan 25, 2024
Merged

fix(instrumentation)!: pin import-in-the-middle@1.7.1#4441
pichlermarc merged 7 commits into
open-telemetry:mainfrom
dynatrace-oss-contrib:fix/iitm-dep

Conversation

@pichlermarc

Copy link
Copy Markdown
Member

Which problem is this PR solving?

import-in-the-middle@1.7.2 and later includes a bug (nodejs/import-in-the-middle#57) where a property we use to distinguish ESM from CJS modules is not present, causing instrumentation to crash end-user apps.

This drops support for ESM instrumentation again for Node.js 18.19 and later.

Short description of the changes

pin import-in-the-middle@1.7.1

Type of change

Please delete options that are not relevant.

  • Bug fix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@codecov

codecov Bot commented Jan 24, 2024

Copy link
Copy Markdown

Codecov Report

Merging #4441 (bd98d83) into main (0635ab1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4441   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         336      336           
  Lines        9515     9515           
  Branches     2017     2017           
=======================================
  Hits         8775     8775           
  Misses        740      740           

@pichlermarc
pichlermarc marked this pull request as ready for review January 24, 2024 18:18
@pichlermarc
pichlermarc requested a review from a team January 24, 2024 18:18
@pichlermarc

Copy link
Copy Markdown
Member Author

cc @trentm

Comment thread experimental/CHANGELOG.md Outdated
@pichlermarc
pichlermarc merged commit 8648313 into open-telemetry:main Jan 25, 2024
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…#4441)

* fix(instrumentation): pin import-in-the-middle@1.7.1

* fix(changelog): add changlog entry

* Update experimental/CHANGELOG.md

Co-authored-by: Trent Mick <trentm@gmail.com>

* fix(changelog): additional details

* fix(changelog): formatting

* fix(changelog): lint

---------

Co-authored-by: Trent Mick <trentm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants