Skip to content

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Jan 19, 2024

Which problem is this PR solving?

Promisify prometheus tests and avoid zalgo problem with the constructor callback.

Short description of the changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Promisified tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Merging #4431 (27ca563) into main (df63272) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 27ca563 differs from pull request most recent head acd1e42. Consider uploading reports for the commit acd1e42 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4431      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         336      336              
  Lines        9521     9516       -5     
  Branches     2017     2018       +1     
==========================================
- Hits         8781     8776       -5     
  Misses        740      740              
Files Coverage Δ
...etry-exporter-prometheus/src/PrometheusExporter.ts 96.29% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

@pichlermarc pichlermarc merged commit bf4d553 into open-telemetry:main Jan 25, 2024
@legendecas legendecas deleted the prometheus branch January 25, 2024 08:10
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…etry#4431)

* refactor(exporter-prometheus): promisify prometheus tests

* fix: lint

---------

Co-authored-by: Marc Pichler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants