refactor(instrumentation-grpc): clean up remnants of 'grpc' package instrumentation - #4420
Merged
pichlermarc merged 8 commits intoJan 31, 2024
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4420 +/- ##
==========================================
+ Coverage 92.37% 92.41% +0.04%
==========================================
Files 331 330 -1
Lines 9518 9497 -21
Branches 2021 2021
==========================================
- Hits 8792 8777 -15
+ Misses 726 720 -6
|
pichlermarc
marked this pull request as ready for review
January 16, 2024 14:27
Flarna
approved these changes
Jan 26, 2024
Flarna
left a comment
Member
There was a problem hiding this comment.
Seems it's mostly a code move/adaption to move.
I haven't looked into each and every line.
dyladan
approved these changes
Jan 31, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…nstrumentation (open-telemetry#4420) * refactor(instrumentation-grpc): clean up remnants of 'grpc' package instrumentation * fix(changelog): add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We had some unused code left over from back when
@opentelemetry/instrumentation-grpcstill supported thegrpcpackage (now only@grpc/gprc-jsis supported). This PR gets rid of the wrapper that used to make two instrumentation look like one.Fixes #4201
Type of change
How Has This Been Tested?
@grpc/grpc-jsto ensure we don't rely on@grpc/grpc-jstypes in the public interface