Skip to content

Conversation

@Lp-Francois
Copy link
Contributor

@Lp-Francois Lp-Francois commented Nov 8, 2023

Which problem is this PR solving?

Make it way easier to visualise metrics scraping by prometheus with a docker-compose file.

Short description of the changes

How Has This Been Tested?

Locally

  1. run npm run install and npm run start to start the web server from the directory.
  2. start prometheus with docker compose up
  3. Go to http://localhost:9090 and observe the prometheus UI with graphs
Screenshot 2023-11-08 at 20 45 50

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Lp-Francois Lp-Francois requested a review from a team November 8, 2023 19:51
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for adding this. 🙂 I've had the situation multiple times where I had to set it up for troubleshooting and this indeed makes it easier.

The linter's a bit unhappy but with the proposed change it should work.

@codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #4268 (5d2cfe8) into main (f2b447d) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 5d2cfe8 differs from pull request most recent head 1cd8ff3. Consider uploading reports for the commit 1cd8ff3 to get more accurate results

@@            Coverage Diff             @@
##             main    #4268      +/-   ##
==========================================
+ Coverage   92.30%   92.40%   +0.10%     
==========================================
  Files         330      323       -7     
  Lines        9417     9282     -135     
  Branches     1993     1953      -40     
==========================================
- Hits         8692     8577     -115     
+ Misses        725      705      -20     

see 8 files with indirect coverage changes

@pichlermarc pichlermarc added document Documentation-related Skip Changelog labels Nov 9, 2023
@pichlermarc pichlermarc merged commit 40fde0f into open-telemetry:main Nov 9, 2023
dyladan added a commit that referenced this pull request Nov 15, 2023
* chore: track package-lock.json (#4238)

* chore: track package-lock.json

* Pin to old versions for node 14

* Use version range

* Remove unused cached directories

* Temporarily disable other tests

* Temporarily enable only api test

* Enable only some packages

* Test only api packages

* Test trace exporters

* Fix line ordering

* Test all packages except otlp exporters

* Add trace http exporter

* Add trace proto exporter

* Test all but grpc exporters

* chore: use npm workspaces and degrade lerna to v6

* chore: get rid of lerna bootstrap

* chore: use npx

* chore: allow install scripts to setup buf

* chore: fix w3c-integration-test cache key

* chore: fix cache key

* chore: disable resource compat test

* chore: fix node_modules assumptions

* chore: fix hoisted karma issue

* chore: fix markdown linter complaints

* chore: lock @grpc/grpc-js to v1.8.21

* Break caches

* chore: remove cache

* chore: fixup inline commands

---------

Co-authored-by: Daniel Dyla <[email protected]>

* docs: fixed link to benchmark results (#4233)

Co-authored-by: Chengzhong Wu <[email protected]>

* chore(deps): update all patch versions (#4215)

* fix: otlp json encoding (#4220)

Co-authored-by: Marc Pichler <[email protected]>

* fix: remove duplicate export star from version.ts (#4225)

Co-authored-by: Marc Pichler <[email protected]>

* docs: fix sdk-node config instructions (#4249)

Co-authored-by: Marc Pichler <[email protected]>

* feat(api): publish api esnext target (#4231)

* chore: release API 1.7.0/Core 1.18.0/Experimental 0.45.0 (#4254)

* fix(sdk-metrics): hand-roll MetricAdvice type as older API versions do not include it (#4260)

* chore: prepare release 1.18.1/0.45.1 (#4261)

* chore: no need for 'packages' in "lerna.json" (#4264)

* Benchmark tests for trace OTLP transform and BatchSpanProcessor (#4218)

Co-authored-by: Marc Pichler <[email protected]>

* chore: type reference on zone.js (#4257)

Co-authored-by: Marc Pichler <[email protected]>

* docs: add docker-compose to run prometheus for the experimental example (#4268)

Co-authored-by: Marc Pichler <[email protected]>

* fix(sdk-logs): avoid map attribute set when count limit exceeded (#4195)

Co-authored-by: Marc Pichler <[email protected]>

* chore(deps): update dependency chromedriver to v119 [security] (#4280)

* chore(deps): update actions/setup-node action to v4 (#4236)

* fix(sdk-trace-base): processor onStart called with a span having empty attributes (#4277)

Co-authored-by: artahmetaj <[email protected]>

* Update fetch instrumentation to be runtime agnostic (#4063)

Co-authored-by: Marc Pichler <[email protected]>

---------

Co-authored-by: Chengzhong Wu <[email protected]>
Co-authored-by: Martin Kuba <[email protected]>
Co-authored-by: Mend Renovate <[email protected]>
Co-authored-by: Siim Kallas <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: David Luna <[email protected]>
Co-authored-by: Dinko Osrecki <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: François <[email protected]>
Co-authored-by: Hyun Oh <[email protected]>
Co-authored-by: André Cruz <[email protected]>
Co-authored-by: artahmetaj <[email protected]>
Co-authored-by: drewcorlin1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Documentation-related Skip Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants