fix(sdk-node) Remove @opentelemetry/exporter-jaeger explicit dependency #4214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismiramirez
force-pushed
the
remove-jaeger-dep
branch
from
d801de1 to
e0aa1ef
Compare
pichlermarc
approved these changes
Oct 19, 2023
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Ah, that must've made it back when merging something. 😞
thanks for removing it.
seemk
pushed a commit
to seemk/opentelemetry-js
that referenced
this pull request
Oct 22, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
@opentelemetry/exporter-jaegerexplicit dependency isn't removed despite what the last changelog saysThis PR removes the dependency.
Type of change
Please delete options that are not relevant.
Checklist: