fix(example-opencensus-shim): avoid OpenCensus auto instrumentations - #3951
Merged
haddasbronfman merged 4 commits intoJun 26, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
+ Coverage 92.91% 92.92% +0.01%
==========================================
Files 297 297
Lines 8838 8838
Branches 1815 1815
==========================================
+ Hits 8212 8213 +1
+ Misses 626 625 -1 |
Flarna
approved these changes
Jun 26, 2023
Member
How is this causing build failures if it is just an example? The code should not run as part of any build. This PR broke the example, following the instructions it no longer runs. |
aabmass
added a commit
to aabmass/opentelemetry-js
that referenced
this pull request
Aug 16, 2023
…tations (open-telemetry#3951)" This reverts commit 15ede47.
4 tasks
aabmass
added a commit
to aabmass/opentelemetry-js
that referenced
this pull request
Aug 16, 2023
…tations (open-telemetry#3951)" This reverts commit 15ede47.
Member
|
Opened a PR to revert. Let's discuss there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently the opencensus-shim example imports
@opencensus/nodejswhich also imports@opencensus/instrumentation-allandgrpcand causes build fails on many platforms.Short description of the changes
Changed
@opencensus/nodejsto@opencensus/nodejs-basewhich does not include instrumentations.Type of change
Please delete options that are not relevant.
Checklist: