chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script - #3833
Merged
pichlermarc merged 10 commits intoMay 26, 2023
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
==========================================
- Coverage 92.95% 91.73% -1.23%
==========================================
Files 297 169 -128
Lines 9060 4672 -4388
Branches 1848 927 -921
==========================================
- Hits 8422 4286 -4136
+ Misses 638 386 -252 |
dyladan
reviewed
May 24, 2023
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
pichlermarc
marked this pull request as ready for review
May 25, 2023 05:47
dyladan
approved these changes
May 25, 2023
dyladan
reviewed
May 25, 2023
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
added
the
Merge:LGTM
JamieDanielson
approved these changes
May 25, 2023
JamieDanielson
left a comment
JamieDanielson
left a comment
Member
There was a problem hiding this comment.
Added a non-blocking suggestion for adding color to make it pop more, otherwise looks good to me.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
JamieDanielson
approved these changes
May 26, 2023
JamieDanielson
left a comment
JamieDanielson
left a comment
Member
There was a problem hiding this comment.
nice! definitely grabs your attention.
This was referenced May 30, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We currently have no proper way to notify users that the 'grpc' package instrumentation code is being removed from the
@opentelemetry/instrumentation-grpcpackage. As discussed in the SIG meeting last week, since the package is not released as stable yet, increasing semver major is not an option.Please feel free to suggest any changes to wording of the changelog/message.
Related #3780, #3807
Type of change
How Has This Been Tested?
postinstallscript locallyChecklist: