fix(instrumentation): only patch core modules if enabled - #2993
Merged
vmarchaud merged 3 commits intoMay 28, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
+ Coverage 92.71% 92.77% +0.06%
==========================================
Files 183 183
Lines 6134 6135 +1
Branches 1299 1300 +1
==========================================
+ Hits 5687 5692 +5
+ Misses 447 443 -4
|
MSNev
approved these changes
May 25, 2022
Otherwise, disabling the instrumentation module before actually requiring the to-be-instrumented module doesn't work, and the module is patched.
santigimeno
force-pushed
the
santi/instrumentation_fix
branch
from
May 26, 2022 07:48
353acc9 to
68e1caa
Compare
|
|
dyladan
approved these changes
May 27, 2022
Member
|
Lint failure not caused by this pull request |
vmarchaud
approved these changes
May 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Otherwise, disabling the instrumentation module before actually
requiring the to-be-instrumented module doesn't work, and the module is
patched.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: