fix(sdk-metrics-base): misbehaving aggregation temporality selector tolerance - #2958
Merged
Merged
Conversation
legendecas
force-pushed
the
metrics-ff/at-call
branch
from
May 10, 2022 11:33
c916dcf to
301e77b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 183 183
Lines 5958 5959 +1
Branches 1266 1266
=======================================
+ Hits 5513 5514 +1
Misses 445 445
|
seemk
approved these changes
May 10, 2022
seemk
left a comment
seemk
left a comment
Contributor
There was a problem hiding this comment.
Completely glanced over this section when you initially mentioned the issue, thanks! 👍
dyladan
approved these changes
May 10, 2022
Member
|
Thanks for moving the changelog entry to the correct section |
# Conflicts: # experimental/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When the AggregationTemporalitySelector returns different AggregationTemporality for the same instrument type, the collection result can be very misleading and incorrect.
Short description of the changes
Type of change
How Has This Been Tested?
Checklist: