feat(sdk-metrics-base): shutdown and forceflush on MeterProvider - #2890
Merged
Conversation
12 tasks
Codecov Report
@@ Coverage Diff @@
## main #2890 +/- ##
==========================================
+ Coverage 92.42% 93.64% +1.21%
==========================================
Files 163 165 +2
Lines 5520 5601 +81
Branches 1160 1177 +17
==========================================
+ Hits 5102 5245 +143
+ Misses 418 356 -62
|
pichlermarc
approved these changes
Apr 8, 2022
pichlermarc
left a comment
Member
There was a problem hiding this comment.
Looks good. Just a few non-blocking comments. 🙂
seemk
approved these changes
Apr 11, 2022
dyladan
approved these changes
Apr 13, 2022
vmarchaud
approved these changes
Apr 15, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Refs: #2593
Short description of the changes
Promise.allType of change
How Has This Been Tested?
Checklist:
Documentation has been updated