Add grpc compression to trace-otlp-grpc exporter - #2813
Merged
legendecas merged 18 commits intoMar 22, 2022
Conversation
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2813 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 163 163
Lines 5572 5572
Branches 1180 1180
=======================================
Hits 5211 5211
Misses 361 361 |
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
dyladan
reviewed
Mar 7, 2022
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
…ntelemetry-js into add-grpc-compression
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
legendecas
approved these changes
Mar 14, 2022
dyladan
reviewed
Mar 14, 2022
dyladan
left a comment
dyladan
left a comment
Member
There was a problem hiding this comment.
Also looks good to me % the same nits as legendecas
Co-authored-by: legendecas <legendecas@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
vmarchaud
approved these changes
Mar 19, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Add gzip compression to OTLP/gRPC trace exporter.
Partially Fixes #2706 (issue)
Short description of the changes
Added compression configuration that will select the compression set by the user (through configuration options or environment variables). Added compression to service client in
onInitmethod inutils.js.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: