Skip to content

Conversation

@jessitron
Copy link
Contributor

@jessitron jessitron commented Sep 16, 2021

Which problem is this PR solving?

These links were broken in the doc

Short description of the changes

I found in git log that the referenced packages were moved. So here are the links to point to their new location.

The line numbers referenced in the links aren't all quite right anymore, but at least the links take you into the right file now.

@jessitron jessitron requested a review from a team September 16, 2021 00:06
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #2478 (da0187d) into main (bebd82a) will increase coverage by 1.12%.
The diff coverage is n/a.

❗ Current head da0187d differs from pull request most recent head ff4bb09. Consider uploading reports for the commit ff4bb09 to get more accurate results

@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
+ Coverage   93.20%   94.32%   +1.12%     
==========================================
  Files         137       96      -41     
  Lines        5017     3347    -1670     
  Branches     1060      717     -343     
==========================================
- Hits         4676     3157    -1519     
+ Misses        341      190     -151     
Impacted Files Coverage Δ
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...kages/opentelemetry-sdk-metrics-base/src/Metric.ts
...elemetry-sdk-metrics-base/src/SumObserverMetric.ts
...ckages/opentelemetry-sdk-metrics-base/src/Utils.ts
...try-sdk-metrics-base/src/export/aggregators/Sum.ts
...y-sdk-metrics-base/src/export/aggregators/index.ts
...elemetry-instrumentation-grpc/src/grpc-js/index.ts
...lemetry-sdk-metrics-base/src/BaseObserverMetric.ts
...ry-instrumentation-grpc/src/grpc-js/clientUtils.ts
...telemetry-sdk-metrics-base/src/export/Processor.ts
... and 32 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Documentation-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants