InstrumentationAbstract#setConfig doesn't honor enabled flag

[Flarna]

• This only affects the JavaScript OpenTelemetry library
• This may affect other libraries, but I would like to get opinions here first

Enabling of an Instrumentation is done automatically if user is not explicit disabling it. See InstrumentationAbstract constructor

If later config is updated using setConfig the config.enabled flag is not evaluated nor defaulted.

Should we add defaulting of enabled in setConfig and also call enable/disable there? Or is it up to the user?

[vmarchaud]

I think we should respect it when defined, othersiwe consider that it should be enabled

[Flarna]

It might be needed to disable and enable an instrumentation to ensure the new settings are applied everywhere. On the other hand this could cause problems if this includes unpatch and repatch.

[dyladan]

I think automatically enabling/disabling is probably dangerous. Maybe instead we could emit some onConfigurationChanged event and let the instrumentations deal with it how they want.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue was closed because it has been stale for 14 days with no activity.