Skip to content

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 19, 2024

Which problem is this PR solving?

Short description of the changes

@trivikr trivikr requested a review from a team as a code owner November 19, 2024 22:43
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙌

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (d0fb135) to head (889ed96).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2542      +/-   ##
==========================================
- Coverage   90.80%   90.75%   -0.05%     
==========================================
  Files         169      169              
  Lines        8018     8018              
  Branches     1632     1632              
==========================================
- Hits         7281     7277       -4     
- Misses        737      741       +4     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@pichlermarc pichlermarc merged commit 162feb1 into open-telemetry:main Nov 21, 2024
20 checks passed
@trivikr trivikr deleted the trivikr-patch-1 branch November 21, 2024 17:23
@trivikr
Copy link
Contributor Author

trivikr commented Nov 21, 2024

Thank you @pichlermarc for reviewing and merging this PR.

Can you approve workflows on #2545?
I want to confirm that it fails the CI, and then push formatting fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants