Skip to content

perf(instrumentation-pg): do not split query to determine operation name #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blumamir merged 3 commits into from
May 22, 2024
Merged

perf(instrumentation-pg): do not split query to determine operation name #2029

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f02641f
perf(instrumentation-pg): do not split query to determine operation name
Samuron Mar 21, 2024
9015ae3
Merge branch 'main' into index_of_command_name
blumamir May 22, 2024
81dc59d
Merge branch 'main' into index_of_command_name
blumamir May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/node/opentelemetry-instrumentation-pg/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,12 @@ export function getQuerySpanName(
}

function parseNormalizedOperationName(queryText: string) {
Copy link
Contributor

@maryliag maryliag Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your commit message says you're changing how to get the "span name", but your changes are on the "operation name" function (even if that is later used to get the span), so probably worth updating commit message/PR title to reflect that.

Copy link
Contributor Author

@Samuron Samuron Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

const sqlCommand = queryText.split(' ')[0].toUpperCase();
const indexOfFirstSpace = queryText.indexOf(' ');
let sqlCommand =
indexOfFirstSpace === -1
? queryText
: queryText.slice(0, indexOfFirstSpace);
sqlCommand = sqlCommand.toUpperCase();

// Handle query text being "COMMIT;", which has an extra semicolon before the space.
return sqlCommand.endsWith(';') ? sqlCommand.slice(0, -1) : sqlCommand;
Expand Down