fix(auto-instrumentations-web)!: Add zone.js as a peerDependency #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
approved these changes
Nov 8, 2023
Member
blumamir
left a comment
blumamir
left a comment
There was a problem hiding this comment.
That makes sense to me 👍
I wonder why the instrumentation's peer dependency in pinned and not caret 🤔, but that's a different topic
blumamir
changed the title
pichlermarc
changed the title
pichlermarc
approved these changes
Nov 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.01%
==========================================
Files 143 143
Lines 7299 7299
Branches 1458 1458
==========================================
+ Hits 6672 6673 +1
+ Misses 627 626 -1 |
Merged
jmcdo29
pushed a commit
to jmcdo29/opentelemetry-js-contrib
that referenced
this pull request
Nov 13, 2023
…n-telemetry#1768) * chore: Add zone.js as a peerDep of auto-instrumentations-web * chore: Empty commit to re-run CI --------- Co-authored-by: Amir Blum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set up a Repro Repo to demonstrate the problem https://github.com/dbasilio/opentelemetry-peer-dep-repro
auto-instrumentations-weblistsinstrumentation-user-interactionas a dependency.instrumentation-user-interactionlists[email protected]as a peerDependency, butauto-instrumentations-webdoesn't satisfy that peerDepedency at all. It needs to be listed as a peerDependency or a dependency (or both) to satisfy the peerDependency from instrumentation-user-interaction`Which problem is this PR solving?
Short description of the changes
auto-instrumentations-web