Skip to content

chore: bump opentelemetry core dependencies#165

Merged
dyladan merged 3 commits into
open-telemetry:masterfrom
dynatrace-oss-contrib:core-deps
Aug 3, 2020
Merged

chore: bump opentelemetry core dependencies#165
dyladan merged 3 commits into
open-telemetry:masterfrom
dynatrace-oss-contrib:core-deps

Conversation

@dyladan

@dyladan dyladan commented Jul 30, 2020

Copy link
Copy Markdown
Member

No description provided.

@dyladan dyladan requested a review from a team July 30, 2020 20:09
@dyladan dyladan added the enhancement New feature or request label Jul 30, 2020
@codecov

codecov Bot commented Jul 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #165 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   94.14%   94.10%   -0.04%     
==========================================
  Files          70       74       +4     
  Lines        3331     3582     +251     
  Branches      335      387      +52     
==========================================
+ Hits         3136     3371     +235     
- Misses        195      211      +16     
Impacted Files Coverage Δ
...opentelemetry-plugin-user-interaction/.eslintrc.js 0.00% <0.00%> (ø)
...lugin-user-interaction/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...try-plugin-user-interaction/src/userInteraction.ts 93.80% <0.00%> (ø)
...entelemetry-plugin-user-interaction/src/version.ts 100.00% <0.00%> (ø)

@dyladan

dyladan commented Jul 30, 2020

Copy link
Copy Markdown
Member Author

@obecny looks like the user interaction plugin is failing on the latest core

@dyladan

dyladan commented Jul 30, 2020

Copy link
Copy Markdown
Member Author

Looks like attributes.component is still in the assertions, but was removed from the xhr plugin in core.

@obecny

obecny commented Jul 30, 2020

Copy link
Copy Markdown
Member

Missing: examples, lerna.json, main package.json

@dyladan

dyladan commented Jul 30, 2020

Copy link
Copy Markdown
Member Author

@obecny this is not the release proposal. this is pumping the dependencies

@obecny

obecny commented Jul 31, 2020

Copy link
Copy Markdown
Member

@obecny this is not the release proposal. this is pumping the dependencies

but in examples should we also update to latest ?

@dyladan

dyladan commented Jul 31, 2020

Copy link
Copy Markdown
Member Author

@obecny this is not the release proposal. this is pumping the dependencies

but in examples should we also update to latest ?

Done

@dyladan dyladan merged commit 7b6450c into open-telemetry:master Aug 3, 2020
@dyladan dyladan deleted the core-deps branch August 3, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants