Skip to content

Conversation

@AasthaMehtaTech
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • After this PR, the version for semver will be upgraded & aligned with other opentelemetry packages in this monorepo.

@AasthaMehtaTech AasthaMehtaTech requested a review from a team August 23, 2023 12:27
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@blumamir
Copy link
Member

Thank you @AasthaMehtaTech for the contribution.

I support aligning the "semver" versions, but A quick search in the repo reveals other packages that still use different versions. There is also inconsistencies with using the caret range.

image

Would you mind aligning these dependencies too? I assume the same security alert will show up there as well.

I think our conventions are to pin dev dependencies since they are not part of the distribution and can introduce breaking changes for our builds and CI. For "dependencies" we do use caret ^ range to allow our users to get bug fixes for packages we depend on. Could be a great opportunity to apply this on "semver" across the repo if you have time and motivation 🙏

@haddasbronfman documented the reasoning here for the core repo as a reference.

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #1646 (f30a23e) into main (0fbacba) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1646   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         139      139           
  Lines        7112     7112           
  Branches     1427     1427           
=======================================
  Hits         6527     6527           
  Misses        585      585           

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants