Skip to content

Conversation

@chigia001
Copy link
Contributor

@chigia001 chigia001 commented Jul 12, 2023

Which problem is this PR solving?

  • restify already release new version 11.1.0 and since 10.0.0 they already add support for node@18
  • instrumentation-restify still testing with version [email protected], which don't suppport node@18

Short description of the changes

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1576 (dd26411) into main (6150def) will decrease coverage by 1.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1576      +/-   ##
==========================================
- Coverage   96.06%   94.93%   -1.14%     
==========================================
  Files          14       21       +7     
  Lines         914     1144     +230     
  Branches      199      237      +38     
==========================================
+ Hits          878     1086     +208     
- Misses         36       58      +22     
Impacted Files Coverage Δ
...telemetry-instrumentation-restify/src/constants.ts 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@chigia001 chigia001 requested a review from blumamir July 16, 2023 04:45
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@haddasbronfman haddasbronfman merged commit 432d89e into open-telemetry:main Jul 16, 2023
@chigia001 chigia001 deleted the upgrade-restify branch July 16, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instrumentation restify: support new versions

5 participants