-
Notifications
You must be signed in to change notification settings - Fork 621
chore(restify): update restify version to 11.1.0 and re-enable unit test in node@18 #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
haddasbronfman
merged 14 commits into
open-telemetry:main
from
chigia001:upgrade-restify
Jul 16, 2023
Merged
chore(restify): update restify version to 11.1.0 and re-enable unit test in node@18 #1576
haddasbronfman
merged 14 commits into
open-telemetry:main
from
chigia001:upgrade-restify
Jul 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
807224a to
bab09d4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
- Coverage 96.06% 94.93% -1.14%
==========================================
Files 14 21 +7
Lines 914 1144 +230
Branches 199 237 +38
==========================================
+ Hits 878 1086 +208
- Misses 36 58 +22
|
…js-contrib into upgrade-restify
pichlermarc
approved these changes
Jul 13, 2023
blumamir
reviewed
Jul 15, 2023
plugins/node/opentelemetry-instrumentation-restify/package.json
Outdated
Show resolved
Hide resolved
blumamir
approved these changes
Jul 16, 2023
Member
blumamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
kirrg001
added a commit
to instana/nodejs
that referenced
this pull request
May 6, 2024
kirrg001
added a commit
to instana/nodejs
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
>=4.0.0 <12