Skip to content

feat(resource-detector-azure)!: update semconv usage to ATTR_ exports, update to semconv v1.37.0#3063

Merged
david-luna merged 4 commits intoopen-telemetry:mainfrom
trentm:trentm-semconv-up-res-det-az
Sep 18, 2025
Merged

feat(resource-detector-azure)!: update semconv usage to ATTR_ exports, update to semconv v1.37.0#3063
david-luna merged 4 commits intoopen-telemetry:mainfrom
trentm:trentm-semconv-up-res-det-az

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Sep 17, 2025

BREAKING CHANGE: This also updates the Semantic Conventions of the
emitted resource attributes from v1.19.0 to v1.37.0 which involves these
breaking changes:

Refs: #2377


BEGIN_COMMIT_OVERRIDE
feat(resource-detector-azure)!: update semconv usage to ATTR_ exports, update to semconv v1.37.0 (#3063)
BREAKING CHANGE: This updates the Semantic Conventions of the emitted resource attributes from v1.19.0 to v1.37.0 which involves these breaking changes:

END_COMMIT_OVERRIDE

BREAKING CHANGE: This also updates the Semantic Conventions of the
emitted resource attributes from v1.19.0 to v1.37.0 which involves these
breaking changes:
- App Service resource detector: `deployment.environment` -> `deployment.environment.name`
  This changed in semconv v1.27.0 as part of
  open-telemetry/semantic-conventions#1075
- Semconv v1.35.0 naming convention changes
  (https://github.com/open-telemetry/semantic-conventions/blob/main/CHANGELOG.md#v1350)
  resulted in a change in the name of some `cloud.platform` values:
    - `azure_app_service` -> `azure.app_service`
    - `azure_vm` -> `azure.vm`
    - `azure_functions` -> `azure.functions`

Refs: open-telemetry#2377
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.43%. Comparing base (d546c4d) to head (44a847d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3063      +/-   ##
==========================================
- Coverage   92.45%   92.43%   -0.02%     
==========================================
  Files         224      220       -4     
  Lines       10694    10669      -25     
  Branches     2211     2211              
==========================================
- Hits         9887     9862      -25     
  Misses        807      807              
Flag Coverage Δ
auto-instrumentations-node 98.24% <ø> (ø)
resource-detector-azure 93.61% <100.00%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tor-azure/src/detectors/AzureAppServiceDetector.ts 100.00% <100.00%> (ø)
...ctor-azure/src/detectors/AzureFunctionsDetector.ts 100.00% <100.00%> (ø)
...ce-detector-azure/src/detectors/AzureVmDetector.ts 78.57% <ø> (ø)
packages/resource-detector-azure/src/semconv.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm trentm changed the title chore(resource-detector-azure)!: update semconv usage to ATTR_ exports feat(resource-detector-azure)!: update semconv usage to ATTR_ exports, update to semconv v1.37.0 Sep 17, 2025
@trentm trentm marked this pull request as ready for review September 17, 2025 22:54
@trentm trentm requested a review from a team as a code owner September 17, 2025 22:54
@david-luna david-luna enabled auto-merge (squash) September 18, 2025 07:13
@david-luna david-luna merged commit 8e1ca48 into open-telemetry:main Sep 18, 2025
16 checks passed
@trentm trentm deleted the trentm-semconv-up-res-det-az branch September 18, 2025 14:05
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Sep 22, 2025
- ignore 'MD007/ul-indent' (https://github.com/DavidAnson/markdownlint/blob/main/doc/md007.md) rule because changelog additions by release-please sometimes use 2-spaces (e.g. https://github.com/open-telemetry/opentelemetry-js-contrib/pull/3033/files#diff-bbed5176d1ba38f7f8f16103189e27b107fd64a1dcfd50fe98e3a24d24c096b7R13-R15) and sometimes use 4-spaces (with commit overrides: open-telemetry#3063 becomes 4-spaces https://github.com/open-telemetry/opentelemetry-js-contrib/pull/3072/files#diff-bbed5176d1ba38f7f8f16103189e27b107fd64a1dcfd50fe98e3a24d24c096b7R8-R14)
- ignore 'MD034/no-bare-urls' (https://github.com/DavidAnson/markdownlint/blob/main/doc/md034.md): The requirement to use angle-brackets is *fine*, but over-strong as a *requirement*, especially when it comes as part of a commit-override in a PR comment. The issue is that the lint failure because subtle/complex.

Refs: open-telemetry#3072 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants