Skip to content

Introduce ESM testing strategy #1731

@pichlermarc

Description

@pichlermarc

Is your feature request related to a problem? Please describe

In the @opentelemetry/instrumentation package, we added experimental ESM support a while ago (open-telemetry/opentelemetry-js#3698). As more and more users started using this, the lack of ESM-releated testing became apparent. A high-priority bug that's present in a large number of instrumentations causes applications to crash as wrapping ES modules fails.

There have been PRs opened to address this; however, as we don't test for ESM, it is hard to verify fixes and catch regressions.

Describe the solution you'd like to see

We should start testing if instrumentations also work with ESM. This issue tracks

  • documenting an ESM testing strategy for existing packages
  • implementing the suggested tests in at least two instrumentation packages
  • adding a step in the unit tests workflow to run the ESM tests

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions