add stdout memory mode #6774

zeitlinger · 2024-10-10T11:33:21Z

No description provided.

codecov · 2024-10-10T11:40:24Z

Codecov Report

Attention: Patch coverage is 94.30380% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (b927d9d) to head (bb62e71).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
...tlp/internal/logs/OtlpStdoutLogRecordExporter.java	86.66%	1 Missing and 1 partial ⚠️
...tlp/internal/metrics/OtlpStdoutMetricExporter.java	89.47%	1 Missing and 1 partial ⚠️
...g/otlp/internal/traces/OtlpStdoutSpanExporter.java	86.66%	1 Missing and 1 partial ⚠️
...r/internal/otlp/logs/LogReusableDataMarshaler.java	95.00%	0 Missing and 1 partial ⚠️
...rnal/otlp/metrics/MetricReusableDataMarshaler.java	95.00%	0 Missing and 1 partial ⚠️
...nternal/otlp/traces/SpanReusableDataMarshaler.java	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6774      +/-   ##
============================================
+ Coverage     90.10%   90.58%   +0.48%     
- Complexity     6541     6582      +41     
============================================
  Files           728      731       +3     
  Lines         19695    19714      +19     
  Branches       1935     1926       -9     
============================================
+ Hits          17746    17858     +112     
+ Misses         1349     1259      -90     
+ Partials        600      597       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zeitlinger · 2024-10-10T13:47:07Z

@jack-berg this is the final PR for stdout - adding the memory mode feature

jack-berg · 2024-10-15T16:21:08Z

...main/java/io/opentelemetry/exporter/logging/otlp/internal/OtlpStdoutExporterBuilderUtil.java

+
+import io.opentelemetry.sdk.common.export.MemoryMode;
+
+public class OtlpStdoutExporterBuilderUtil {


Missing internal boilerplate javadoc.

why did the build not fail?

There's not a build check for it right now. Do you know if opentelemetry-java-instrumentation managed to add this automation yet?

oh, I didn't upstream it here, check out https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/custom-checks/src/main/java/io/opentelemetry/javaagent/customchecks/OtelInternalJavadoc.java

Opened new issue here: #6798

...main/java/io/opentelemetry/exporter/logging/otlp/internal/OtlpStdoutExporterBuilderUtil.java

...mon/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/LogReusableDataMarshaler.java

...n/java/io/opentelemetry/exporter/logging/otlp/internal/logs/OtlpStdoutLogRecordExporter.java

jack-berg · 2024-10-15T16:39:10Z

...n/java/io/opentelemetry/exporter/logging/otlp/internal/logs/OtlpStdoutLogRecordExporter.java

+        }
+      }.export(logs);
    } else {
      for (ResourceLogsMarshaler resourceLogs : ResourceLogsMarshaler.create(logs)) {


It doesn't seem to be the case that if wrapperJsonObject = false, we can't take advantage of reuseable memory mode. Can we include wrapperJsonObject as an argument to LogReuseableDataMarshaler and adjust the logic accordingly?

that's not so easy, because

opentelemetry-java/exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/LowAllocationLogsRequestMarshaler.java

Line 55 in 715211e

public void initialize(Collection<LogRecordData> logDataList) {

takes a list and I didn't follow what has to be modified in there

Ok let's punt on it for now

...n/java/io/opentelemetry/exporter/logging/otlp/internal/metrics/OtlpStdoutMetricExporter.java

zeitlinger · 2024-10-17T06:18:52Z

@jack-berg can you trigger the failed link check? otherwise, everything should be fine

...mon/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/LogReusableDataMarshaler.java

jack-berg

Looks good besides the missing internal boilerplate javadoc. Thanks!

add stdout memory mode

ef927c7

zeitlinger requested a review from a team as a code owner October 10, 2024 11:33

zeitlinger mentioned this pull request Oct 10, 2024

OTLP Stdout exporter #6632

Closed

zeitlinger self-assigned this Oct 10, 2024

jack-berg reviewed Oct 15, 2024

View reviewed changes

zeitlinger added 2 commits October 16, 2024 08:41

pr review

9ce3fec

pr review

cfabe23

zeitlinger force-pushed the stdout-memory-mode branch from d5021a9 to cfabe23 Compare October 16, 2024 10:19

jack-berg mentioned this pull request Oct 16, 2024

Add build automation to ensure internal classes have required javadoc boilerplate #6798

Closed

jack-berg reviewed Oct 17, 2024

View reviewed changes

...mon/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/LogReusableDataMarshaler.java Show resolved Hide resolved

jack-berg approved these changes Oct 17, 2024

View reviewed changes

internal class note

bb62e71

jack-berg merged commit 1ac476b into open-telemetry:main Oct 17, 2024
17 checks passed

zeitlinger deleted the stdout-memory-mode branch November 4, 2024 06:44


		import io.opentelemetry.sdk.common.export.MemoryMode;

		public class OtlpStdoutExporterBuilderUtil {

add stdout memory mode #6774

add stdout memory mode #6774

Uh oh!

Conversation

zeitlinger commented Oct 10, 2024

Uh oh!

codecov bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zeitlinger commented Oct 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zeitlinger commented Oct 17, 2024

Uh oh!

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 10, 2024 •

edited

Loading