log: add error field to Record and make SDK to emit exception attributes#7924
Merged
dmathieu merged 15 commits intoopen-telemetry:mainfrom Mar 5, 2026
Merged
log: add error field to Record and make SDK to emit exception attributes#7924dmathieu merged 15 commits intoopen-telemetry:mainfrom
dmathieu merged 15 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7924 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 304 304
Lines 23389 23424 +35
=====================================
+ Hits 19094 19132 +38
+ Misses 3907 3904 -3
Partials 388 388
🚀 New features to boost your workflow:
|
pellared
reviewed
Feb 18, 2026
pellared
reviewed
Feb 18, 2026
pellared
reviewed
Feb 20, 2026
dashpole
reviewed
Feb 20, 2026
pellared
reviewed
Feb 20, 2026
pellared
reviewed
Feb 23, 2026
pellared
reviewed
Feb 23, 2026
pellared
reviewed
Feb 24, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Member
|
#7924 (comment) this comment is not addressed and the linter is failing. Side note: Overall the PR looks nice 😉 💪 |
pellared
reviewed
Feb 25, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Contributor
Author
Sorry I thought with the introduced changes was ok. I did some modifications and I think it should be correct now. Please, let me know if you want some other change or I'm missing something else.
I was not sure about fixing this or not because #7924 (comment) Will fix in a better way. |
pellared
reviewed
Feb 27, 2026
pellared
reviewed
Feb 27, 2026
pellared
reviewed
Feb 27, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
pellared
reviewed
Mar 5, 2026
dmathieu
approved these changes
Mar 5, 2026
Co-authored-by: Damien Mathieu <42@dmathieu.com>
pellared
added a commit
that referenced
this pull request
Mar 6, 2026
### Added - Add `go.opentelemetry.io/otel/semconv/v1.40.0` package. The package contains semantic conventions from the `v1.40.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.40.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.39.0`. (#7985) - Add `Err` and `SetErr` on `Record` in `go.opentelemetry.io/otel/log` to attach an error and set record exception attributes in `go.opentelemetry.io/otel/log/sdk`. (#7924) ### Changed - `TracerProvider.ForceFlush` in `go.opentelemetry.io/otel/sdk/trace` joins errors together and continues iteration through SpanProcessors as opposed to returning the first encountered error without attempting exports on subsequent SpanProcessors. (#7856) ### Fixed - Fix missing `request.GetBody` in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` to correctly handle HTTP2 GOAWAY frame. (#7931) - Fix semconv v1.39.0 generated metric helpers skipping required attributes when extra attributes were empty. (#7964) - Preserve W3C TraceFlags bitmask (including the random Trace ID flag) during trace context extraction and injection in `go.opentelemetry.io/otel/propagation`. (#7834) ### Removed - Drop support for [Go 1.24]. (#7984)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7923
$ go test -run=^$ -bench=BenchmarkLoggerEmitExceptionAttributes -benchmem -count=5 -benchtime=500ms -cpu=1 goos: darwin goarch: arm64 pkg: go.opentelemetry.io/otel/sdk/log cpu: Apple M4 Pro BenchmarkLoggerSetErrAndEmit 628162 1023 ns/op 5371 B/op 1 allocs/op BenchmarkLoggerSetErrAndEmit 663955 863.3 ns/op 5105 B/op 1 allocs/op BenchmarkLoggerSetErrAndEmit 653888 1067 ns/op 5177 B/op 1 allocs/op BenchmarkLoggerSetErrAndEmit 716438 824.8 ns/op 4764 B/op 1 allocs/op BenchmarkLoggerSetErrAndEmit 746902 999.2 ns/op 5630 B/op 1 allocs/op BenchmarkLoggerSetExceptionAttributesAndEmit 650696 1042 ns/op 5200 B/op 1 allocs/op BenchmarkLoggerSetExceptionAttributesAndEmit 574962 980.7 ns/op 4743 B/op 1 allocs/op BenchmarkLoggerSetExceptionAttributesAndEmit 536736 989.2 ns/op 5049 B/op 1 allocs/op BenchmarkLoggerSetExceptionAttributesAndEmit 558511 1190 ns/op 4870 B/op 1 allocs/op BenchmarkLoggerSetExceptionAttributesAndEmit 669452 978.8 ns/op 5067 B/op 1 allocs/op PASS ok go.opentelemetry.io/otel/sdk/log 6.994sTODO after merged: