Fix/issue 6560 install trace bridge test#6814
Merged
dmathieu merged 10 commits intoopen-telemetry:mainfrom May 26, 2025
Merged
Conversation
…st verifies that TraceID, SpanID, TraceOptions, and Tracestate are correctly converted from OpenTelemetry to OpenCensus format. Fixes open-telemetry#6561
highlyavailable
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu and
pellared
as code owners
highlyavailable
force-pushed
the
fix/issue-6560-install-trace-bridge-test
branch
2 times, most recently
from
3a8ddb9 to
5f1bb30
Compare
Remove verbose comment Co-authored-by: Damien Mathieu <42@dmathieu.com>
Remove verbose comment Co-authored-by: Damien Mathieu <42@dmathieu.com>
Remove verbose comment Co-authored-by: Damien Mathieu <42@dmathieu.com>
MrAlias
approved these changes
May 23, 2025
highlyavailable
force-pushed
the
fix/issue-6560-install-trace-bridge-test
branch
from
5d45827 to
66e7398
Compare
…fy that the octrace.DefaultTracer is correctly set when the function is called with various configuration options. Fixes open-telemetry#6560
highlyavailable
force-pushed
the
fix/issue-6560-install-trace-bridge-test
branch
from
66e7398 to
7a8b1ad
Compare
dmathieu
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6560
Summary
Adds tests for the
InstallTraceBridgefunction to verify that theoctrace.DefaultTraceris correctly set when the function is called with various configuration options.Changes
TestInstallTraceBridgetest function inbridge/opencensus/trace_test.gooctrace.DefaultTraceris properly updated.Test Results