bridge/opencensus: add test for OTelSpanContextToOC function#6813
Merged
MrAlias merged 6 commits intoopen-telemetry:mainfrom May 23, 2025
Merged
bridge/opencensus: add test for OTelSpanContextToOC function#6813MrAlias merged 6 commits intoopen-telemetry:mainfrom
MrAlias merged 6 commits intoopen-telemetry:mainfrom
Conversation
…st verifies that TraceID, SpanID, TraceOptions, and Tracestate are correctly converted from OpenTelemetry to OpenCensus format. Fixes open-telemetry#6561
highlyavailable
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu and
pellared
as code owners
dmathieu
reviewed
May 23, 2025
Remove verbose comment Co-authored-by: Damien Mathieu <42@dmathieu.com>
Remove verbose comment Co-authored-by: Damien Mathieu <42@dmathieu.com>
Remove verbose comment Co-authored-by: Damien Mathieu <42@dmathieu.com>
Contributor
Author
|
@dmathieu Thanks for the feedback, I removed the verbose comments. |
dmathieu
approved these changes
May 23, 2025
MrAlias
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for the
OTelSpanContextToOCfunc in theopencensus bridgeas requested in issue #6561.Changes
TestOTelSpanContextToOCfunction with four test cases:Testing
The test verifies that the following fields are correctly converted:
All existing tests continue to pass.
Fixes
Closes #6561