Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 26, 2025

Ensure consistent line wrapping (<= 120 characters) within the project.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 26, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 26, 2025
@MrAlias MrAlias force-pushed the golines branch 4 times, most recently from 0cb1bcd to c330933 Compare March 26, 2025 19:29
@MrAlias MrAlias marked this pull request as ready for review March 26, 2025 19:35
@pellared
Copy link
Member

pellared commented Mar 27, 2025

I think it is worth mentioning https://go.dev/doc/effective_go#formatting:

Go has no line length limit. Don't worry about overflowing a punched card. If a line feels too long, wrap it and indent with an extra tab.

My initial thought are to use 120 max line limit as suggested by @XSAM.

I will think about it more and look at the PR later.

Side note: interesting article https://knox.codes/posts/line-length-limits.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 suggestions, but none is a deal-breaker:

Manual consolidation of long verticals.
@MrAlias MrAlias merged commit 7512a2b into open-telemetry:main Mar 30, 2025
30 checks passed
@MrAlias MrAlias deleted the golines branch March 30, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants