-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add the golines golangci-lint formatter
#6513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0cb1bcd to
c330933
Compare
exporters/otlp/otlpmetric/otlpmetricgrpc/internal/oconf/envconfig_test.go
Show resolved
Hide resolved
|
I think it is worth mentioning https://go.dev/doc/effective_go#formatting:
My initial thought are to use 120 max line limit as suggested by @XSAM. I will think about it more and look at the PR later. Side note: interesting article https://knox.codes/posts/line-length-limits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 suggestions, but none is a deal-breaker:
Configure to wrap at 120 characters.
Ensure consistent line wrapping (<= 120 characters) within the project.