Skip to content

Conversation

@bryan-aguilar
Copy link
Contributor

This is a defensive PR to update the minimum go versions used in GHA workflows. The latest go releases contain security related fixes.

@MrAlias MrAlias merged commit 01d64c3 into open-telemetry:main Sep 6, 2023
@pellared
Copy link
Member

pellared commented Sep 7, 2023

Would it not be easier for us to use https://github.com/actions/setup-go#check-latest-version?

EDIT: See my review for reference: open-telemetry/opentelemetry-go-instrumentation#264 (review)

@bryan-aguilar
Copy link
Contributor Author

bryan-aguilar commented Sep 7, 2023

Would it not be easier for us to use https://github.com/actions/setup-go#check-latest-version?

Yup, check-latest would also be useful. I would still suggest forcing the minimum version through the go-version field in the case of high severity cves though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants