Skip to content

Conversation

@unicod3
Copy link
Contributor

@unicod3 unicod3 commented Feb 26, 2023

Resolves #3768

Hello, this is my first contribution to this repo so tried to tackle this good first issue.

I've restructured the compatibility tests accordingly to what was discussed in last week's meeting (2023-02-23).

Also renamed the token job's name to test-compatibility so it is aligned with other test jobs.

You can see it in action in the link below:
https://github.com/unicod3/opentelemetry-go/actions/runs/4272402129/jobs/7437568975

Please let me know if I missed anything.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 26, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: unicod3 / name: Sinan Ülker (9c6f1ce)

@dmathieu
Copy link
Member

I'm not sure this requires a changelog entry.

@unicod3
Copy link
Contributor Author

unicod3 commented Feb 26, 2023

I'm not sure this requires a changelog entry.

Agreed, I wasn't sure either tbh, removed it from PR.

@unicod3 unicod3 requested a review from MrAlias February 26, 2023 20:48
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comment (with proposed changed)

Thanks for contribution.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 27, 2023
@unicod3 unicod3 requested review from MrAlias and pellared and removed request for MrAlias and pellared February 27, 2023 11:02
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #3779 (a2a34dd) into main (071d317) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3779     +/-   ##
=======================================
- Coverage   81.6%   81.6%   -0.1%     
=======================================
  Files        167     167             
  Lines      12453   12453             
=======================================
- Hits       10173   10171      -2     
- Misses      2065    2067      +2     
  Partials     215     215             
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restructure compatibility testing workflow to depend on stable job

6 participants