Remove metric instrument provider API - #3530
Merged
Merged
Conversation
MrAlias
added
pkg:API
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
=======================================
- Coverage 78.1% 77.9% -0.2%
=======================================
Files 164 163 -1
Lines 11826 11850 +24
=======================================
- Hits 9237 9233 -4
- Misses 2391 2419 +28
Partials 198 198
|
MrAlias
marked this pull request as ready for review
December 8, 2022 23:11
MrAlias
requested review from
Aneurysm9,
MadVikingGod,
XSAM,
dashpole,
dmathieu,
evantorrie,
hanyuancheung,
jmacd and
pellared
as code owners
December 8, 2022 23:11
dashpole
approved these changes
Dec 9, 2022
hanyuancheung
approved these changes
Dec 9, 2022
Contributor
|
I have posted my objections to this in the primary issue: #3454 (comment) Assuming that we resolve that, I think this is an acceptable way of closing the issue. |
jmacd
approved these changes
Dec 16, 2022
Contributor
Author
|
@MadVikingGod based on the SIG meeting discussion it seemed your issue was addressed. Are you okay with merging this? |
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jan 3, 2023
MrAlias
added a commit
that referenced
this pull request
Jan 4, 2023
* Rename metric SDK instrument kind to match API Follow up to #3530. * Update CHANGELOG Fix trailing spaces and update PR number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3454
Move all instrument provider instrument creation functionality to the
Meteras required by the OpenTelemetry specification.