Skip to content

Update API configs. #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MrAlias merged 9 commits into from
May 27, 2021
Merged

Update API configs. #1921

MrAlias merged 9 commits into from
May 27, 2021

Conversation

@MadVikingGod
Copy link
Contributor

@MadVikingGod MadVikingGod commented May 14, 2021 •
edited by MrAlias
Loading

This change will update the configs in the base API, go.opentelemetry.io/otel/trace and go.opentelemetry.io/otel/metric`, to reflect our contributing documentation.

Because these configs are consumed by the SDK, and any other alternative implementation, they can not be private. This also means that the members of these configs will need some accessor.

This will finish the last items of #1882, closes #536

In addition, this reorganizes spanOptions to prevent ignored options from being accepted in any steps. For example Span.End() no longer accepts attributes or links. Closes #1878

@codecov
Copy link

codecov bot commented May 14, 2021 •
edited
Loading

Codecov Report

Merging #1921 (5ee455a) into main (270cc60) will increase coverage by 0.1%.
The diff coverage is 85.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1921     +/-   ##
=======================================
+ Coverage   79.5%   79.6%   +0.1%     
=======================================
  Files        141     141             
  Lines       7464    7486     +22     
=======================================
+ Hits        5941    5966     +25     
+ Misses      1275    1271      -4     
- Partials     248     249      +1
Impacted Files Coverage Δ
bridge/opentracing/bridge.go 47.8% <0.0%> (ø)
bridge/opentracing/wrapper.go 100.0% <ø> (ø)
trace/noop.go 46.1% <0.0%> (ø)
trace/trace.go 83.6% <ø> (ø)
metric/metric.go 52.5% <75.0%> (ø)
trace/config.go 75.5% <75.0%> (+14.9%) ⬆️
bridge/opentracing/internal/mock.go 72.7% <77.7%> (ø)
bridge/opencensus/bridge.go 84.9% <100.0%> (ø)
internal/global/meter.go 90.3% <100.0%> (ø)
internal/global/trace.go 83.7% <100.0%> (ø)
... and 9 more

Aneurysm9
Aneurysm9 reviewed May 14, 2021
View reviewed changes
Aneurysm9
Aneurysm9 reviewed May 18, 2021
View reviewed changes
@MadVikingGod MadVikingGod marked this pull request as ready for review May 20, 2021 14:36
@MadVikingGod MadVikingGod changed the title WIP Update API configs. Update API configs. May 20, 2021
@MrAlias MrAlias added this to the RC1 milestone May 20, 2021
MrAlias
MrAlias reviewed May 25, 2021
View reviewed changes
MrAlias
MrAlias reviewed May 26, 2021
View reviewed changes
@MrAlias
Copy link
Contributor

MrAlias commented May 26, 2021

I'm not sure about the lint failure, they look unrelated to the changes introduced here. Other than the syntax error this all looks good! 😄

@MadVikingGod
Copy link
Contributor Author

MadVikingGod commented May 26, 2021

That is so strange. I got the error 123 once, but after re-running make I couldn't get it to reproduce. I also used the go test explorer extension, and all came back green.

@MrAlias
Copy link
Contributor

MrAlias commented May 27, 2021

That is so strange. I got the error 123 once, but after re-running make I couldn't get it to reproduce. I also used the go test explorer extension, and all came back green.

🤷

@MrAlias MrAlias merged commit c1f460e into open-telemetry:main May 27, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
Merged
@MadVikingGod MadVikingGod deleted the fix-trace-config branch February 21, 2023 19:55
MrAlias added a commit that referenced this pull request May 20, 2025
@MrAlias
Add semconv/v1.32.0 (#6782)
2d4c9dc 
- Add the new metric API package structure prototyped in
https://github.com/MrAlias/semconv-go

  Prototypes of new metric API use:
   - MrAlias/opentelemetry-go-contrib#6136
   - MrAlias/opentelemetry-go-contrib#6135
   - MrAlias/opentelemetry-go-contrib#6134
- Generate `semconv/v1.32.0`
- Drop the `kestrel` metric namespace as this is a Java specific
technology

## [`v1.32.0` semantic convention release
notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.32.0):

<div data-pjax="true" data-test-selector="body-content"
data-view-component="true" class="markdown-body my-3"><p>📣 This release
is the second release candidate for the Database Semantic Conventions,
with <strong>db conventions stability planned to be declared in the
subsequent release</strong>.</p>
<h3>🛑 Breaking changes 🛑</h3>
<ul>
<li><code>device</code>: Change the definition of <code>device.id</code>
and make it opt-in. (<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1951"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1951/hovercard">#1951</a>)</li>
<li><code>feature_flag</code>: Rename <code>evaluation</code> to
<code>result</code> for feature flag evaluation result attributes (<a
href="open-telemetry/semantic-conventions#1989"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1989/hovercard">#1989</a>)</li>
</ul>
<h3>🚀 New components 🚀</h3>
<ul>
<li><code>app</code>: Create <code>app.installation.id</code> attribute
(<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1897"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1897/hovercard">#1897</a>)</li>
<li><code>cpython</code>: Add CPython runtime garbage collector metrics
(<a
href="open-telemetry/semantic-conventions#1930"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1930/hovercard">#1930</a>)</li>
</ul>
<h3>💡 Enhancements 💡</h3>
<ul>
<li><code>vcs</code>: Add owner and provider name to VCS attribute
registry (<a
href="open-telemetry/semantic-conventions#1452"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1452/hovercard">#1452</a>)</li>
<li><code>vcs</code>: Remove fallback value for VCS provider name
attribute (<a
href="open-telemetry/semantic-conventions#2020"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2020/hovercard">#2020</a>)</li>
<li><code>db</code>: Truncate <code>db.query.summary</code> to 255
characters if parsed from the query (<a
href="open-telemetry/semantic-conventions#1978"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1978/hovercard">#1978</a>)</li>
<li><code>db</code>: Normalize spaces in <code>db.operation.name</code>
(if any) (<a
href="open-telemetry/semantic-conventions#2028"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2028/hovercard">#2028</a>)</li>
<li><code>db</code>: <code>db.operation.parameter.&lt;key&gt;</code>
should not be captured for batch operations (<a
href="open-telemetry/semantic-conventions#2026"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2026/hovercard">#2026</a>)</li>
<li><code>db</code>: Add <code>db.stored_procedure.name</code> (<a
href="open-telemetry/semantic-conventions#1491"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1491/hovercard">#1491</a>)</li>
<li><code>gcp</code>: Adds GCP AppHub labels for resource. (<a
href="open-telemetry/semantic-conventions#2006"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2006/hovercard">#2006</a>)</li>
<li><code>error</code>: Add <code>error.message</code> property for
human-readable error message on events. (<a
href="open-telemetry/semantic-conventions#1992"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1992/hovercard">#1992</a>)</li>
<li><code>profile</code>: Extend the list of known frame types with a
value for Go and Rust (<a
href="open-telemetry/semantic-conventions#2003"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2003/hovercard">#2003</a>)</li>
<li><code>otel</code>: Adds SDK self-monitoring metrics for log
processing (<a
href="open-telemetry/semantic-conventions#1921"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1921/hovercard">#1921</a>)</li>
</ul>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

+1 more reviewer

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

RC1

Development

Successfully merging this pull request may close these issues.

Links provided to Span.End are silently dropped Unify Configuration and Initialization

3 participants

@MadVikingGod @MrAlias @Aneurysm9