Add a split protocol driver for otlp exporter #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a wrapper around two other protocol drivers, so it makes it possible to send traces using a different protocol than the one used for metrics.
krnowak
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
========================================
+ Coverage 78.5% 78.6% +0.1%
========================================
Files 125 126 +1
Lines 6324 6369 +45
========================================
+ Hits 4966 5011 +45
Misses 1114 1114
Partials 244 244
|
jmacd
approved these changes
Dec 22, 2020
XSAM
approved these changes
Dec 22, 2020
MrAlias
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split driver takes two other drivers and uses one of them for sending traces and another for sending metrics.
Closes #1121
Closes #1202