Skip to content

Fix typo in otelhttp - #7175

Merged
dmathieu merged 3 commits into
open-telemetry:mainfrom
MueR:patch-1
Apr 9, 2025
Merged

Fix typo in otelhttp#7175
dmathieu merged 3 commits into
open-telemetry:mainfrom
MueR:patch-1

Conversation

@MueR

@MueR MueR commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

This pull request fixes a typo in the net/http otel instrumentation. The const lablelerContextKey was renamed to labelerContextKey.

@MueR
Fix typo in otelhttp
f050777 
This pull request fixes a typo in the net/http otel instrumentation. The const `lablelerContextKey` was renamed to `labelerContextKey`.
@MueR
MueR requested review from a team and dmathieu as code owners April 8, 2025 07:25
@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MueR / name: Bas (f050777)
  • ✅ login: dmathieu / name: Damien Mathieu (2e263ee)
  • ✅ login: pellared / name: Robert Pająk (0b704ec)

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Apr 8, 2025
@codecov

codecov Bot commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.7%. Comparing base (3ed2c06) to head (2e263ee).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7175   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        205     205           
  Lines      18083   18083           
=====================================
  Hits       14601   14601           
  Misses      3062    3062           
  Partials     420     420
Files with missing lines Coverage Δ
instrumentation/net/http/otelhttp/labeler.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pellared
pellared approved these changes Apr 8, 2025
View reviewed changes

@pellared pellared left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dmathieu
dmathieu merged commit 1c40c30 into open-telemetry:main Apr 9, 2025
@MueR
MueR deleted the patch-1 branch April 9, 2025 07:21
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes
@pellared pellared pellared approved these changes
@MrAlias MrAlias MrAlias approved these changes
@XSAM XSAM XSAM approved these changes
+1 more reviewer
@codeboten codeboten codeboten approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Milestone

v1.36.0

Development

Successfully merging this pull request may close these issues.

6 participants

@MueR @dmathieu @codeboten @pellared @MrAlias @XSAM