Add emicklei/go-restful instrumentation - #115
Merged
Merged
Conversation
A filter may be added at any one of the following: * container scope * webservice scope * route scope Includes a docker-compose example with instructions.
evantorrie
requested review from
Aneurysm9,
MrAlias,
jmacd,
lizthegrey and
paivagustavo
as code owners
June 30, 2020 17:26
Aneurysm9
approved these changes
Jun 30, 2020
MrAlias
approved these changes
Jul 1, 2020
MrAlias
left a comment
MrAlias
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, nothing blocking.
Did we want to move this to github.com/emicklei/go-restful? I know we had talked about this for the other instrumentation that is missing it as well. Maybe a subsequent PR to move everything?
Contributor
Author
Yes, I planned a subsequent PR to move everything from github.com under a github.com directory. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #79
A filter may be added at any one of the following:
Includes a docker-compose example with instructions.