Repository navigation
[SDK] Handle denied environment variable access - #8070
Merged
Kielek merged 3 commits intoOct 30, 2026
Merged
Conversation
Handle denied environment access during initial load and reload. Keep the last successful snapshot and allow later recovery. Preserve readable resource configuration and host defaults. Addresses Codex Security Cloud finding commit:4caf64fc74c48191ab4ac4df4c3318fe.
Pull request dashboard statusMerged · refreshed 2026-10-30 15:43 UTC Status above doesn't look right?
|
Document the SDK, OTLP, Zipkin, Prometheus HttpListener, and hosting fixes with their contribution link to PR open-telemetry#8070. Addresses Codex Security Cloud finding commit:4caf64fc74c48191ab4ac4df4c3318fe.
Kielek
marked this pull request as ready for review
October 30, 2026 13:25
martincostello
left a comment
Member
There was a problem hiding this comment.
Feels a bit OTT in practice, but it centralises some otherwise duplicated call blocks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8070 +/- ##
==========================================
- Coverage 90.76% 90.73% -0.03%
==========================================
Files 382 382
Lines 22581 22580 -1
Branches 4179 4178 -1
==========================================
- Hits 20495 20489 -6
- Misses 1503 1506 +3
- Partials 583 585 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Separate switch sections, fail explicitly on unexpected result types, and qualify types instead of adding one-use namespace imports throughout the modified files. Addresses Codex Security Cloud finding commit:4caf64fc74c48191ab4ac4df4c3318fe.
Kielek
force-pushed
the
codex/handle-denied-environment-access
branch
from
October 30, 2026 14:28
1e6d489 to
75e31dc
Compare
martincostello
approved these changes
Oct 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2026
6 of 8 tasks
This was referenced Nov 11, 2026
This was referenced Nov 16, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Codex Security Cloud finding:
commit:4caf64fc74c48191ab4ac4df4c3318fe.Changes
Denied environment-variable access can throw
SecurityExceptionduring SDK/exporter initialization or configuration reload. Register a guarded environment provider at all 10 construction sites. Failed initial loads use defaults; failed reloads retain the last successful snapshot and allow a later retry. Guard deferred key reads in resource detection and the shared typed readers as well.Regression tests exercise real permission denial on .NET Framework, reload recovery, readable resource values, host defaults, and propagation of other exception types. No public API changes.
Merge requirement checklist
CHANGELOG.mdfile(s) updated for non-trivial changesNote
This PR description was generated with OpenAI Codex.
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩