Repository navigation
[traces] Fix tracing bridge cleanup on older target frameworks - #8065
Merged
martincostello merged 3 commits intoOct 29, 2026
Merged
Conversation
Align provider cleanup guards with tracing bridge attachment and extend hosting regression coverage to .NET Framework. Follow-up to open-telemetry#6899. Discovered by Codex Security Cloud, finding commit:3cccd8cddf68819197beb149951962f6.
Pull request dashboard statusMerged · refreshed 2026-10-29 14:42 UTC Status above doesn't look right?
|
Link the Unreleased entry to PR open-telemetry#8065. Discovered by Codex Security Cloud, finding commit:3cccd8cddf68819197beb149951962f6.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8065 +/- ##
==========================================
- Coverage 90.76% 90.72% -0.04%
==========================================
Files 382 382
Lines 22574 22574
Branches 4177 4177
==========================================
- Hits 20490 20481 -9
- Misses 1505 1510 +5
- Partials 579 583 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
marked this pull request as ready for review
October 29, 2026 13:20
martincostello
approved these changes
Oct 29, 2026
Kielek
enabled auto-merge
October 29, 2026 13:24
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 29, 2026
This was referenced Nov 16, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6899.
Changes
Fix tracing-bridge cleanup on older target frameworks in the
ITracingBuilderintegration added by #6899. Attachment uses
!NET10_0, but cleanup usedNET11_0_OR_GREATER, leaving the bridge attached in thenet462,netstandard2.0and
netstandard2.1SDK assets. If the factory and source outlive the provider,new activities can still invoke sampling after shutdown or call a disposed sampler.
Align all cleanup guards with attachment and enable the existing tracing-builder
integration tests on .NET Framework. Add
Microsoft.Extensions.Diagnostics11 onlyto the older-framework test target so it can call
AddTracing; the shippedpackages gain no dependency. Found through Codex Security Cloud.
Merge requirement checklist
CHANGELOG.mdfile(s) updated for non-trivial changesNote
This PR description was generated with OpenAI Codex.
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩