Repository navigation
[SDK] Skip downscaling empty exponential histogram buckets - #8064
Merged
martincostello merged 2 commits intoOct 29, 2026
Merged
martincostello merged 2 commits into
martincostello merged 2 commits into
Conversation
Return before consolidating an empty bucket range, including allocated storage retained after reset. Add regression coverage for buffer reuse and scaling both histogram sign buffers after reset. Discovered by Codex Security Cloud, finding commit:82bed21962488191a99815deefea29f7.
Pull request dashboard statusMerged · refreshed 2026-10-29 13:52 UTC Status above doesn't look right?
|
Document the fix in the OpenTelemetry changelog and link upstream PR open-telemetry#8064. Discovered by Codex Security Cloud, finding commit:82bed21962488191a99815deefea29f7.
martincostello
approved these changes
Oct 29, 2026
Kielek
enabled auto-merge
October 29, 2026 12:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8064 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 382 382
Lines 22574 22574
Branches 4177 4177
=======================================
Hits 20486 20486
- Misses 1506 1507 +1
+ Partials 582 581 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 29, 2026
This was referenced Nov 11, 2026
This was referenced Nov 16, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Downscaling exponential histogram buckets after reset could throw
IndexOutOfRangeExceptionbecause the retained storage was mistaken for anonempty bucket range. Return before consolidation when the bucket range is
empty, preserving the storage for subsequent recordings.
Add 12 regression cases covering reset and never-allocated buffers, multiple
scaling levels, both histogram sign directions, and subsequent recording.
Before the fix, eight cases failed with the reported exception and four controls
passed. All 12 cases pass after the fix on net11.0, net10.0, and net472.
Fixes to: #7911
Found by Codex internal scans
Merge requirement checklist
CHANGELOG.mdfile(s) updated for non-trivial changesNote
This PR description was generated with OpenAI Codex.
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩