Repository navigation
[Geneva] Fix fuzz tests - #4162
Merged
martincostello merged 1 commit intoApr 21, 2026
Merged
Conversation
Handle case where `SerializeString_Offset_Near_Buffer_End_Does_Not_Throw` would generate inputs that would throw an exception as the encoded string is too large for the buffer.
martincostello
marked this pull request as ready for review
April 20, 2026 14:47
martincostello
enabled auto-merge
April 20, 2026 14:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4162 +/- ##
==========================================
- Coverage 73.83% 73.80% -0.04%
==========================================
Files 466 458 -8
Lines 18314 18272 -42
==========================================
- Hits 13523 13485 -38
+ Misses 4791 4787 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an intermittent failure in the Geneva exporter fuzz tests by ensuring SerializeString_Offset_Near_Buffer_End_Does_Not_Throw only exercises inputs that actually fit in the remaining buffer space.
Changes:
- Add a guard in
SerializeString_Offset_Near_Buffer_End_Does_Not_Throwto skip cases where the UTF-8 encoded string cannot fit in the remaining buffer. - Tighten
SerializeString_Buffer_Too_Small_Throwsto assert the thrown exception type is one of the expected buffer-overflow-related exceptions. - Add a replay-based repro test intended to capture the previously observed failure seed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kielek
approved these changes
Apr 21, 2026
Merged
via the queue into
open-telemetry:main
with commit Apr 21, 2026
a32c828
154 of 157 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Handle case where
SerializeString_Offset_Near_Buffer_End_Does_Not_Throwwould generate inputs that would throw an exception as the encoded string is too large for the buffer.Example
Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)