Skip to content

[ServiceFabricRemoting] Respect TransportSettings - #4148

Merged
martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:respect-ServiceFabricRemoting-config
Apr 21, 2026
Merged

martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:respect-ServiceFabricRemoting-config

Conversation

@martincostello

Copy link
Copy Markdown
Member

Changes

Respect any user-configured TransportSettings options that are used.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Respect any user-configured TransportSettings options are used.
@github-actions github-actions Bot added the comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting label Apr 17, 2026
@codecov

codecov Bot commented Apr 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (2514553) to head (209161f).
⚠️ Report is 18 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ContextEnrichedServiceRemotingProviderAttribute.cs 48.14% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4148      +/-   ##
==========================================
+ Coverage   73.05%   73.22%   +0.17%     
==========================================
  Files         466      458       -8     
  Lines       18210    18186      -24     
==========================================
+ Hits        13303    13317      +14     
+ Misses       4907     4869      -38     
Flag Coverage Δ
unittests-Instrumentation.Cassandra ?
unittests-Instrumentation.ServiceFabricRemoting 40.83% <48.14%> (+6.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ContextEnrichedServiceRemotingProviderAttribute.cs 38.18% <48.14%> (+38.18%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello
martincostello marked this pull request as ready for review April 17, 2026 12:23
@martincostello
martincostello requested a review from a team as a code owner April 17, 2026 12:23
Copilot AI review requested due to automatic review settings April 17, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Service Fabric Remoting instrumentation to respect user-configured TransportSettings by loading FabricTransportRemotingSettings/FabricTransportRemotingListenerSettings defaults from configuration before applying attribute overrides.

Changes:

  • Load remoting/client and listener settings from the TransportSettings configuration section when creating V2 listeners and client factories.
  • Add unit tests validating that configured transport defaults are preserved and attribute overrides still apply.
  • Document the behavior change in the ServiceFabricRemoting changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests/ServiceFabricRemotingTests.cs Adds tests for configured transport defaults and introduces a shared lock for static test hooks.
test/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests.csproj Links the shared Lock shim into the test project.
src/OpenTelemetry.Instrumentation.ServiceFabricRemoting/ServiceRemoting/TraceContextEnrichedServiceRemotingProviderAttribute.cs Loads configured transport settings via TryLoadFrom and applies attribute overrides on top.
src/OpenTelemetry.Instrumentation.ServiceFabricRemoting/CHANGELOG.md Adds an Unreleased entry describing the TransportSettings behavior change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address review comment.

@Kielek Kielek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMRS

@martincostello
martincostello added this pull request to the merge queue Apr 21, 2026
Merged via the queue into open-telemetry:main with commit 3836a01 Apr 21, 2026
74 checks passed
@martincostello
martincostello deleted the respect-ServiceFabricRemoting-config branch April 21, 2026 07:29
@sablancoleis

Copy link
Copy Markdown
Contributor

Hi @martincostello, I don't see an issue linked to this PR. Did somebody report this issue? What was the problem that this PR fixes?

@martincostello

Copy link
Copy Markdown
Member Author

@sablancoleis An issue was privately reported where doing new FabricTransportRemotingSettings() meant that any other settings that might be configured in the default configuration file wouldn't be applied.

@sablancoleis

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants