Repository navigation
[ServiceFabricRemoting] Respect TransportSettings - #4148
martincostello merged 3 commits into
Conversation
Respect any user-configured TransportSettings options are used.
Add PR number.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4148 +/- ##
==========================================
+ Coverage 73.05% 73.22% +0.17%
==========================================
Files 466 458 -8
Lines 18210 18186 -24
==========================================
+ Hits 13303 13317 +14
+ Misses 4907 4869 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the Service Fabric Remoting instrumentation to respect user-configured TransportSettings by loading FabricTransportRemotingSettings/FabricTransportRemotingListenerSettings defaults from configuration before applying attribute overrides.
Changes:
- Load remoting/client and listener settings from the
TransportSettingsconfiguration section when creating V2 listeners and client factories. - Add unit tests validating that configured transport defaults are preserved and attribute overrides still apply.
- Document the behavior change in the ServiceFabricRemoting changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests/ServiceFabricRemotingTests.cs | Adds tests for configured transport defaults and introduces a shared lock for static test hooks. |
| test/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests.csproj | Links the shared Lock shim into the test project. |
| src/OpenTelemetry.Instrumentation.ServiceFabricRemoting/ServiceRemoting/TraceContextEnrichedServiceRemotingProviderAttribute.cs | Loads configured transport settings via TryLoadFrom and applies attribute overrides on top. |
| src/OpenTelemetry.Instrumentation.ServiceFabricRemoting/CHANGELOG.md | Adds an Unreleased entry describing the TransportSettings behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address review comment.
|
Hi @martincostello, I don't see an issue linked to this PR. Did somebody report this issue? What was the problem that this PR fixes? |
|
@sablancoleis An issue was privately reported where doing |
|
@martincostello, thank you for fixing this. I added a little more explanation to the changelog in my active PR. Let me know if you disagree: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/4163/changes#diff-11a9eb23d75bae5c4d705311afccecbd5efc13a52fd1daf627d341c97bcd6c80:~:text=Fixed%20a%20bug,the%20loaded%20values. |
Changes
Respect any user-configured
TransportSettingsoptions that are used.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)