[grafana] Add exemplar-to-logs navigation#3617
Open
cijothomas wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
helm-update-required
cijothomas
force-pushed
the
grafana/exemplar-logs-navigation
branch
2 times, most recently
from
88ec43f to
c8e75a6
Compare
Comment on lines
+25
to
+31
| # Jump from a metric exemplar straight to the matching logs in OpenSearch. The | ||
| # grafana-opensearch-datasource plugin doesn't implement Grafana's trace-link export | ||
| # interface, so we can't use `datasourceUid` here like we do for Jaeger. Instead this links | ||
| # to the existing Demo Dashboard's Log Records panel, setting its $traceId variable and | ||
| # forcing $service to "All" (a trace typically spans multiple services, and we don't know | ||
| # in advance which ones). $traceId is a strict additional filter on top of $service -- the | ||
| # user can still narrow back down to one service afterwards using the dropdown. |
Member
There was a problem hiding this comment.
Do we need this whole text here?
Maybe we can add a link to a doc page.
Member
Author
There was a problem hiding this comment.
there is no doc page yet... Once this is in, I can prepare opentelemetry.io/docs/demo and then come back and remove this.. Not sure if there is any better place to keep this information right now.
Assisted-by: Claude Sonnet 5
cijothomas
force-pushed
the
grafana/exemplar-logs-navigation
branch
from
c8e75a6 to
3f2fd2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds exemplar-to-logs navigation. Clicking an exemplar now offers a "View in Logs (OpenSearch)" link
that opens the Demo Dashboard's Log Records panel pre-filtered to that trace ID.
The
Servicefilter is now multi-select with an "All" option, so the trace's logs across everyservice involved are shown by default.
traceIdis an additional filter on top ofService(notan override), so you can still narrow back down to one service afterwards.
Exemplar shows link to get to Logs:
The dashboard opened when clicking "View in Logs", filtered by the
TraceIdand showing all services:I kept this very minimal, to showcase how one can use Metric Exemplars to get to Logs (instead of just Traces). Happy to further adjust based on feedback. This in itself should be an improvement in my opinion.