chore: use pre-built nginx otel image - #2614
Merged
Merged
Conversation
erka
marked this pull request as ready for review
October 2, 2025 14:32
rogercoll
approved these changes
Oct 2, 2025
julianocosta89
approved these changes
Oct 2, 2025
julianocosta89
left a comment
julianocosta89
left a comment
Member
There was a problem hiding this comment.
This is a great clean-up @erka!
Thank you 🤩
Would you mind adding a changelog?
erka
changed the title
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Contributor
Author
|
@julianocosta89 I've updated the changelog. |
julianocosta89
approved these changes
Oct 2, 2025
Contributor
Author
|
@julianocosta89 there is something wrong with the runner. It's been running more than 90 minutes already. |
Member
|
@erka Yeah, I think something happened on GH side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use prebuilt nginx with otel instead of manual installation
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.